New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MTS Dragonfly bootloader back after accidental removal from pr #7131 #7480

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
4 participants
@klaas019
Contributor

klaas019 commented Jul 11, 2018

Description

Accidently removed mts_dragonfly bootloader when adding new mts_mdot bootloader

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr added the needs: review label Jul 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 12, 2018

@klaas019 Could you ammend the commit message so that it reflects this PR a bit better?

Also, would you mind referencing which PR originally removed the file?

@klaas019 klaas019 changed the title from Add files via upload to Added MTS Dragonfly bootloader back after accidental removal. Jul 12, 2018

@klaas019 klaas019 changed the title from Added MTS Dragonfly bootloader back after accidental removal. to Added MTS Dragonfly bootloader back after accidental removal from pr #7131. Jul 12, 2018

@klaas019

This comment has been minimized.

Contributor

klaas019 commented Jul 12, 2018

Is that correct?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 12, 2018

Close but not quite.
The commit itself should be updated to reflect the changes.

Take a look at git commit --amend to modify the commit mesasge.

@cmonr

cmonr approved these changes Jul 12, 2018

@cmonr cmonr added needs: work and removed needs: review labels Jul 12, 2018

@0xc0170 0xc0170 changed the title from Added MTS Dragonfly bootloader back after accidental removal from pr #7131. to Add MTS Dragonfly bootloader back after accidental removal from pr #7131 Jul 13, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jul 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2018

/morph build

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jul 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2018

Will wait for the commit to be updated

@klaas019

This comment has been minimized.

Contributor

klaas019 commented Jul 19, 2018

I believe I did this correctly

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2650
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7480/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 23, 2018

@cmonr cmonr merged commit 25bb200 into ARMmbed:master Jul 23, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9161 cycles (-459 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7480 from klaas019/master
Add MTS Dragonfly bootloader back after accidental removal from pr ARMmbed#7131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment