New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Correct cmse lib creating with make_gcc_arm exporter #7500

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 12, 2018

Description

This is an interesting one: we run the constructor, but not the link
method from the mbedToolchain classes in any exporter. As such, the
toolchains must make sure to include all of the important flags during
the __init__ method.

This PR puts another, quite important, flag into the constructor.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy theotherjimmy requested a review from deepikabhavnani Jul 12, 2018

@cmonr cmonr added the needs: review label Jul 12, 2018

@@ -234,10 +237,6 @@ def link(self, output, objects, libraries, lib_dirs, mem_map):
map_file = splitext(output)[0] + ".map"
cmd = self.ld + ["-o", output, "-Wl,-Map=%s" % map_file] + objects + ["-Wl,--start-group"] + libs + ["-Wl,--end-group"]
# Create Secure library

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Jul 12, 2018

Contributor

This comment should also be removed

This comment has been minimized.

@theotherjimmy

theotherjimmy Jul 12, 2018

Contributor

Fixed (via rebase).

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-gcc-v8m-export branch 3 times, most recently from 610275e to 6178af3 Jul 12, 2018

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-gcc-v8m-export branch from 6178af3 to ef7b466 Jul 12, 2018

@deepikabhavnani

Looks good to me

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 13, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 13, 2018

Build : SUCCESS

Build number : 2599
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7500/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 13, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 9667b5e into ARMmbed:master Jul 14, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9595 cycles (-873 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 14, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7500 from theotherjimmy/fix-gcc-v8m-export
Tools: Correct cmse lib creating with make_gcc_arm exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment