New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature itm fix #7504

Merged
merged 2 commits into from Jul 18, 2018

Conversation

Projects
None yet
6 participants
@TacoGrandeTX
Contributor

TacoGrandeTX commented Jul 12, 2018

Description

The ITM must be initialized before the SoftDevice, but due to the lazy initialization in C++ on (at least) GCC the ITM init call might happen too late.

This commit moves the initialization code into the NRF52 system startup file and cleans up preprocessor styling.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

marcuschangarm and others added some commits Jun 29, 2018

Fix ITM on NRF52 series
The ITM must be initialized before the SoftDevice, but due to the
lazy initialization in C++ on (at least) GCC the ITM init call
might happen too late.

This commit moves the initialization code into the NRF52 system
startup file.

@0xc0170 0xc0170 requested a review from marcuschangarm Jul 13, 2018

@@ -263,7 +264,7 @@ static bool errata_115(void)
if ((*(uint32_t *)0x10000130ul == 0x8ul) && (*(uint32_t *)0x10000134ul == 0x0ul)){
return true;
}

This comment has been minimized.

@0xc0170

0xc0170 Jul 13, 2018

Member

Introducing new spaces? please remove

This comment has been minimized.

@TacoGrandeTX

TacoGrandeTX Jul 17, 2018

Contributor

Sorry - failed to mention in the commit message that I reversed the whitespace changes that @marcuschangarm made which you previously commented on. A review of "all commits" looks clean w.r.t. whitespace.

@0xc0170 0xc0170 added the needs: work label Jul 13, 2018

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 17, 2018

Build : SUCCESS

Build number : 2625
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7504/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: work labels Jul 18, 2018

@cmonr cmonr merged commit dd6482b into ARMmbed:master Jul 18, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10067 cycles (-401 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment