Feature itm fix #7504
Merged
Feature itm fix #7504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ITM must be initialized before the SoftDevice, but due to the lazy initialization in C++ on (at least) GCC the ITM init call might happen too late. This commit moves the initialization code into the NRF52 system startup file.
0xc0170
requested changes
Jul 13, 2018
| @@ -263,7 +264,7 @@ static bool errata_115(void) | |||
| if ((*(uint32_t *)0x10000130ul == 0x8ul) && (*(uint32_t *)0x10000134ul == 0x0ul)){ | |||
| return true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Introducing new spaces? please remove
There was a problem hiding this comment.
Sorry - failed to mention in the commit message that I reversed the whitespace changes that @marcuschangarm made which you previously commented on. A review of "all commits" looks clean w.r.t. whitespace.
0xc0170
approved these changes
Jul 17, 2018
|
/morph build |
Build : SUCCESSBuild number : 2625 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2264 |
Test : SUCCESSBuild number : 2372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ITM must be initialized before the SoftDevice, but due to the lazy initialization in C++ on (at least) GCC the ITM init call might happen too late.
This commit moves the initialization code into the NRF52 system startup file and cleans up preprocessor styling.
Pull request type