New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Wrong return code for JoinRequest retry #7520

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
4 participants
@hasnainvirk
Contributor

hasnainvirk commented Jul 16, 2018

Description

51f92b0 introduced handling for connection attempts while a connection was already underway or have been
completed. Unfortunately a similar check slipped through and the stack was not able to continue
sending join requests if an error happened.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
LoRaWAN: Wrong return code for JoinRequest retry
51f92b0 introduced
handling for connection attempts while a connection was already underway or have been
completed. Unfortunately a similar check slipped through and the stack was not able to continue
sending join requests if an error happened.
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Jul 16, 2018

@0xc0170 @cmonr Please review. Kevin is on vacation so there wont be anybody reviewing from WAN team. It's a one liner, so please go ahead and review.

@cmonr

cmonr approved these changes Jul 16, 2018

LGTM

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 16, 2018

/morph build

@cmonr cmonr added the needs: CI label Jul 16, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 16, 2018

Build : SUCCESS

Build number : 2613
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7520/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 16, 2018

Not sure what happened here. Rerunning.

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jul 19, 2018

@cmonr cmonr merged commit d91d3a6 into ARMmbed:master Jul 19, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 794 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9959 cycles (-80 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7520 from hasnainvirk/cont_join_issue
LoRaWAN: Wrong return code for JoinRequest retry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment