New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootloader configuration parameters for MAX32625PICO #7523

Merged
merged 1 commit into from Aug 10, 2018

Conversation

Projects
None yet
6 participants
@khariya
Contributor

khariya commented Jul 16, 2018

Description

Tested with MAX32625PICO in bootloader mode (default).
Tested override using mbed_app.json for non-bootloader mode.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jul 17, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 17, 2018

Build : SUCCESS

Build number : 2620
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7523/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2018

@khariya Can you review exporters failure? It's related to device packs.

I believe it is related to this change "device_name": "MAX32625" . Is this valid device name?

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Jul 17, 2018

@khariya

This comment has been minimized.

Contributor

khariya commented Jul 18, 2018

I found same error when Maxim pack was not installed, keil_without_pack.txt

No error after installing the Maxim pack: keil_with_pack.txt

I believe the device name is valid. Would you mind checking if the pack is installed correctly?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

Will get the pack installed in our CI, and rerun once it's good to go.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 20, 2018

IOTTESTINF-3041

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 25, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 26, 2018

/morph export-build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 26, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 26, 2018

/morph mbed2-build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 26, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 27, 2018

The failure in the last exporter looks like the device pack still not present, we will investigate

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

Going to re-run, just in case: /morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

/morph export-build

2 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 1, 2018

/morph export-build

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 1, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 2, 2018

@khariya Thanks for looking into the issue. We're also looking to reproduce the issue locally on our side as well.

Could you confirm that http://www.mxim.net/microcontroller/pack/Maxim.MAX32650.1.1.0-a.pack is the correct pack that we should be installing?

@khariya

This comment has been minimized.

Contributor

khariya commented Aug 2, 2018

@cmonr Here's the pack for MAX32625: http://www.mxim.net/microcontroller/pack/Maxim.MAX32625.1.0.0.pack

Your link is for the MAX32650 target.

@cmonr cmonr added needs: work and removed needs: CI labels Aug 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 7, 2018

Needs work on our end. Still waiting on the CI update.

@khariya

This comment has been minimized.

Contributor

khariya commented Aug 7, 2018

An update for MAX32625 pack has been released:
http://www.mxim.net/microcontroller/pack/Maxim.MAX32625.1.1.0-a.pack

It fixed the problem on my local machine.

Keil version 5.25.2.0
Compiler version 5.06 update 6

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 9, 2018

Pack should now be installed.

Restarting with build since last build is older than a week.
/morph build

@cmonr cmonr closed this Aug 9, 2018

@0xc0170 0xc0170 removed the needs: work label Aug 9, 2018

@cmonr cmonr reopened this Aug 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 9, 2018

Sorry, absolutely no idea what happened there.

@cmonr cmonr added the needs: CI label Aug 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 9, 2018

Build : SUCCESS

Build number : 2773
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7523/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 9, 2018

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 10, 2018

@cmonr cmonr merged commit 54f40a0 into ARMmbed:master Aug 10, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8868 cycles (-948 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 10, 2018

Looks like some of the files in this commit have been renamed and then edited in the same commit. This causes problems for 'git am' and makes it extremely difficult to patch. @khariya please try not to do this in the future. Moving this to 5.10

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 10, 2018

@ARMmbed/mbed-os-maintainers
Is this documented somwhere? I recall seeing this kind of mistake made every once in a while, but unless it's documented publically somewhere, I tend to not hold it against the PR owner.

@khariya

This comment has been minimized.

Contributor

khariya commented Aug 10, 2018

@adbridge is there a way to check this locally before creating the PR?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 13, 2018

@khariya I'm not sure how you could check it. It looks like the recommended way of doing things is 'git mv' for renaming files, you could try this in the future ?

@khariya khariya deleted the maximmbed:max32625pico-bl-updates branch Aug 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

@khariya It helps if file move commits are seperate from file changes.

If they are together, then the patch application process becomes incredibly sensitive to the order of operations (file change then move, vs file move then changed) and I don't know what the process defaults to.

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7523 from maximmbed/max32625pico-bl-updates
Add bootloader configuration parameters for MAX32625PICO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment