New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra ARMc6 instance in unique mapping #7544

Merged
merged 1 commit into from Jul 19, 2018

Conversation

Projects
None yet
5 participants
@cmonr
Contributor

cmonr commented Jul 18, 2018

Description

This recent commit (https://github.com/ARMmbed/mbed-os/pull/7302/files#diff-8ae3dde46b55f3a922724cd3585922b2) added ARMc6 which ends up multiplicly defining ARMc6 in what is suppose to be a set with unique entries.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested review from theotherjimmy, 0xc0170 and studavekar Jul 18, 2018

@cmonr cmonr added the needs: review label Jul 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 18, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 18, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

Going to try this again since CI is now quiet.

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

@ARMmbed/mbed-os-maintainers Thoughts about bringing this in without CI?
@ARMmbed/mbed-os-test

Details: The original CI problem was that when the mbed compile -S or other -S commands are used, the CI build pipeline fails before the PR can even be applied. Because of this, no PRs will be aleo to run until this PR is merged in, which creates a cyclical dependency.
I've opened a ticket in Jira asking for a possible Jenkins change/update, but wanted to discuss this alternative as well.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 19, 2018

Different note: A failed export job appears to indicate that IAR builds are having network and/or machine issues: http://mbed-os.s3-eu-west-1.amazonaws.com/builds/exporter/7479/FAIL/K82F/make_iar/86491627bf80d1b5e5d3b92dabc242d556304e0c_exporter_build_log_K82F_make_iar.txt

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 19, 2018

CI IAR issue still needs to be fixed anyway, I'll talk to @OPpuolitaival.

I would like to have this green asap

@0xc0170 0xc0170 changed the title from Removed extra ARMc6 instance in unique mapping to Remove extra ARMc6 instance in unique mapping Jul 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2642
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7544/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 49ae504 into ARMmbed:master Jul 19, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10172 cycles (+15 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 19, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7544 from cmonr/fix-make.py
Remove extra ARMc6 instance in unique mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment