New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Add Uvision6 exporter #7569

Merged
merged 11 commits into from Aug 27, 2018

Conversation

Projects
None yet
7 participants
@theotherjimmy
Contributor

theotherjimmy commented Jul 20, 2018

Description

This PR adds a new exporter: uvision6. This new exporter shares an
IDE and template with the uvision5 exporter, changing the compiler
used by the exported project from Arm compiler 5 to Arm compiler 6.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change
@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 20, 2018

*** Using Compiler 'V6.9', folder: 'C:\Keil_v5\ARM\ARMCLANG\Bin'
Build target '7559_export_test'
<built-in>(327): warning: In file included from...
<command line>(5): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define data-sections 1
            ^
<command line>(6): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define no-armcc-pragma-push-pop 1
          ^
<command line>(8): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define no-armcc-pragma-anon-unions 1
          ^
<command line>(8): warning: 'no' macro redefined [-Wmacro-redefined]
#define no-armcc-pragma-anon-unions 1
        ^
<command line>(6): note: previous definition is here
#define no-armcc-pragma-push-pop 1
@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 23, 2018

@deepikabhavnani Those are all technically warnings. Did the build error?

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 23, 2018

Sorry missed the error in copy paste

*** Using Compiler 'V6.9', folder: 'C:\Keil_v5\ARM\ARMCLANG\Bin'
Build target '7559_export_test'
<built-in>(327): warning: In file included from...
<command line>(5): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define data-sections 1
            ^
<command line>(6): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define no-armcc-pragma-push-pop 1
          ^
<command line>(8): **error:** macro name must be an identifier
#define 0 1
        ^
<command line>(10): warning: ISO C99 requires whitespace after the macro name [-Wc99-extensions]
#define no-exceptions 1
          ^
<command line>(10): warning: 'no' macro redefined [-Wmacro-redefined]
#define no-exceptions 1
        ^
<command line>(6): note: previous definition is here
#define no-armcc-pragma-push-pop 1
        ^
<command line>(31): **error**: macro name must be an identifier
#define ... 1
        ^
<built-in>(1): **error: '**.mbed_config.h' file not found
#include ".mbed_config.h"
         ^~~~~~~~~~~~~~~~
4 warnings and 3 errors generated.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:uvision-armc6 branch from 148567f to 9f00a9b Aug 8, 2018

theotherjimmy added some commits Aug 8, 2018

@deepikabhavnani

Verified with M2351 👍

@cmonr

cmonr approved these changes Aug 14, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Aug 14, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2791
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 14, 2018

@theotherjimmy Looks like this has broken uvision5 :( Please investigate

@adbridge adbridge added needs: work and removed needs: CI labels Aug 14, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

Test results appear to be due to NRF51 devices in a bad state. Power cycled, but not restarted since this PR needs work.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

Is this intended for 5.10 (as labelled) ? in case yes, this needs update soon otherwise we shall remove the label

@cmonr cmonr added the risk: G label Aug 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 23, 2018

@0xc0170 It is. The internal PREQ is IOTMORF-1258

@cmonr cmonr added risk: A and removed risk: G labels Aug 24, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 24, 2018

@adbridge Fixed. Quotes and such.

@theotherjimmy theotherjimmy added needs: CI and removed needs: work labels Aug 24, 2018

@cmonr cmonr added risk: G and removed risk: A labels Aug 25, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 25, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 25, 2018

Build : SUCCESS

Build number : 2904
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 25, 2018

@cmonr cmonr merged commit 543d6c2 into ARMmbed:master Aug 27, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.1%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 587 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10392 cycles (+1188 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the risk: G label Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment