New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Greentea TCP test cases to timeout less in connection errors #7578

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
5 participants
@VeijoPesonen
Contributor

VeijoPesonen commented Jul 23, 2018

Description

Makes Greentea TCP test cases to timeout less in connection errors

Made to prevent timeout if a single test case fails. The goal is that
each test case might wait only half of the remaining time reserved for
running TCP test cases.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Jul 23, 2018

@SeppoTakalo, @jarlamsa please check.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Jul 23, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 25, 2018

@VeijoPesonen Can you add some more context to the commit msg (included here in the comment but not part of the code change) ?

Good questions to be asked : if this is fixing something, how and why is it fixing?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jul 25, 2018

Makes Greentea TCP test cases to timeout less in connection errors
Made to prevent timeout if a single test case fails. The goal is that
each test case might wait only half of the remaining time reserved for
running TCP test cases.

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:conn_failure_tolerance branch from 23d37a8 to dd6ec03 Jul 26, 2018

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Jul 26, 2018

@0xc0170 Sorry for the bad explanation. Hopefully the latest commit message provides sufficient information.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Jul 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 26, 2018

Build : SUCCESS

Build number : 2675
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7578/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 5d4f636 into ARMmbed:master Jul 26, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8974 cycles (-710 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 26, 2018

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:conn_failure_tolerance branch Jul 27, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7578 from VeijoPesonen/conn_failure_tolerance
Makes Greentea TCP test cases to timeout less in connection errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment