Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix double low power ticker interrupt #7599
When computing the next set_interrupt time in the common ticker layer
To prevent this unnecessary interrupt this patch changes the
Pull request type
Build number : 2789
Build number : 2419
To check I understand this correctly:
The schedule_interrupt tick conversion rounded down, that rounded-down tick was in the past, so it scheduled an immediate interrupt. That interrupt triggered, but ticker_irq_handler decided it wasn't time yet, so rescheduled. Repeat, spinning interrupts, until time is reached? Seems like it could be more than just double, potentially?
If that's right, then approved.
Slightly wary of it going in a patch release unless it's causing a real observed problem - vaguely possible someone's timing is somehow relying on that spin to get more accurate scheduling - it was working a bit like
This failed as it failed to fetch the test app from AWS