New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default SPI CS pin to SD card on MTB #7642

Merged
merged 1 commit into from Aug 1, 2018

Conversation

Projects
None yet
4 participants
@ashok-rao
Contributor

ashok-rao commented Jul 30, 2018

Description

Changing default SPI CS pin on MXCHIP MTB to SD card adapter on the target. This is required for Simple Mbed Cloud Client example when using SD card as default storage.

@0xc0170 / @cmonr what tests would be required for this? Can you please let me know so I can provide relevant logs as required? Thanks.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 30, 2018

Changing default SPI CS pin on MXCHIP MTB to SD card adapter on the target. This is required for Simple Mbed Cloud Client example when using SD card as default storage.

Besides CI tests, this should be a good candidate . So if confirmed working, 👍

@0xc0170 0xc0170 added the needs: CI label Jul 30, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Jul 30, 2018

Thanks @0xc0170 . Yes, this is confirmed to be working with Simple MCC example running successfully on this target. I will also wait for CI results. Thanks.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 31, 2018

Build : SUCCESS

Build number : 2697
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7642/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 31, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 1, 2018

@0xc0170 0xc0170 merged commit 2ec9915 into ARMmbed:master Aug 1, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8998 cycles (-672 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 1, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7642 from ashok-rao/SPI_CS_fix
Changing default SPI CS pin to SD card on MTB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment