New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear CONN_IN_PROGRESS flag after incomplete connect() #7661

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
6 participants
@EnsilicaEdd
Contributor

EnsilicaEdd commented Jul 31, 2018

Description

An incomplete connect() (either abandoned with a disconnect() or just failed of its own accord) would cause subsequent calls to connect() to fail with LORAWAN_STATUS_BUSY due to the CONN_IN_PROGRESS_FLAG remaining set in _ctrl_flags.

This change clears that flag in the two cases described.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
An incomplete connect (either abandoned with a disconnect() or just
failed of its own accord) would prevent futher connect()'s  due to the
CONN_IN_PROGRESS_FLAG remaining set.  This change clears that flag in
the two cases described.
@hasnainvirk

Looks like a nice catch of an edge case and really good solution. Thanks @EnsilicaEdd . +1

@0xc0170

0xc0170 approved these changes Aug 1, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 1, 2018

Build : SUCCESS

Build number : 2715
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7661/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 1, 2018

/morph mbed2-build

@cmonr cmonr merged commit 35fb35a into ARMmbed:master Aug 2, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 793 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9566 cycles (-104 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Aug 2, 2018

@EnsilicaEdd EnsilicaEdd deleted the EnsilicaEdd:fix_lorawan_incomplete_connect branch Aug 2, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7661 from EnsilicaEdd/fix_lorawan_incomple…
…te_connect

Clear CONN_IN_PROGRESS flag after incomplete connect()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment