New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanostack: fix error code #7678

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
5 participants
@juhaylinen
Contributor

juhaylinen commented Aug 2, 2018

Description

Return NSAPI_ERROR_NO_MEMORY if socket->open() fails

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Aug 2, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Aug 3, 2018

Please change this to NO_MEMORY error. NO_SOCKET is used when someone uses Socket class without opening it first, or if stack has somehow lost the socket id.

Nanostack: fix error code
Return NSAPI_ERROR_NO_MEMORY if socket->open() fails

@juhaylinen juhaylinen force-pushed the juhaylinen:fix-nanostack-return-code branch from a864a99 to 942b772 Aug 3, 2018

@juhaylinen

This comment has been minimized.

Contributor

juhaylinen commented Aug 3, 2018

@SeppoTakalo change done

@0xc0170

0xc0170 approved these changes Aug 3, 2018

@juhaylinen

This comment has been minimized.

Contributor

juhaylinen commented Aug 7, 2018

Changes approved. How about starting the CI?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 7, 2018

Build : SUCCESS

Build number : 2750
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7678/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 7, 2018

@cmonr cmonr merged commit 616e14a into ARMmbed:master Aug 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 705 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9614 cycles (+31 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 7, 2018

@juhaylinen juhaylinen deleted the juhaylinen:fix-nanostack-return-code branch Aug 8, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment