New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: fix target update list #7689

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
6 participants
@0xc0170
Member

0xc0170 commented Aug 3, 2018

Description

Not only new target, any target update goes to own section. This covers
target updates to SDK, HAL implementation, target list, etc.
All these go to patch releases.

what about Feature - this is for features, but also shall cover new functionality (is this clear enough that even adding new function to public API this makes it "feature"?) ?

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
PR template: fix target update list
Not only new target, any target update goes to own section. This covers
target updates to SDK, HAL implementation, target list, etc.
All these go to patch releases.
@adbridge

This comment has been minimized.

Contributor

adbridge commented on 61f12b4 Aug 3, 2018

👍

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Aug 3, 2018

@cmonr

cmonr approved these changes Aug 3, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 5, 2018

@0xc0170 does this need CI? (I've put the label on since it seems to be approved on review, but I'm not sure if this needs an actual CI run)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

@0xc0170 does this need CI? (I've put the label on since it seems to be approved on review, but I'm not sure if this needs an actual CI run)

Yes please. Will start one

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2735
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7689/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

/morph mbed2-build

@cmonr cmonr merged commit 6561a7f into ARMmbed:master Aug 6, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 705 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9622 cycles (+39 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 6, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7689 from 0xc0170/fix_pr_template
PR template: fix target update list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment