New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netsocket: astyle fix #7692

Merged
merged 2 commits into from Aug 7, 2018

Conversation

Projects
None yet
6 participants
@0xc0170
Member

0xc0170 commented Aug 3, 2018

Description

AStyle fix for netsockets

@ARMmbed/mbed-os-ipcore Please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Aug 3, 2018

0x20, 0x01, 0x16, 0x08, 0, 0x10, 0, 0x25, // DNS.WATCH
0, 0, 0, 0, 0x1c, 0x04, 0xb1, 0x2f
}
},

This comment has been minimized.

@0xc0170

0xc0170 Aug 3, 2018

Member

There is just this change that looks fine but not same as the rest of the lines above.

@SeppoTakalo shall I manually fix it?

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Aug 3, 2018

Contributor

Uhhh.. I did not spot this..
Astyle is trying to be clever and avoiding oneliners. If you cant somehow prevent these lines to be changed, please do.

This comment has been minimized.

@0xc0170

0xc0170 Aug 6, 2018

Member

Fixed in 88a7416 commit

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Aug 6, 2018

@cmonr

cmonr approved these changes Aug 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2747
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7692/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 7, 2018

/morph mbed2-build

@cmonr cmonr merged commit d84bf7f into ARMmbed:master Aug 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 679 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9133 cycles (-1043 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 7, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 10, 2018

This relies on #7192 which is scheduled for 5.10

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

@0xc0170 0xc0170 deleted the 0xc0170:fix_netsocket_style branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment