New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashIAP: Add a ROM end macro #7705

Merged
merged 1 commit into from Aug 7, 2018

Conversation

Projects
None yet
6 participants
@davidsaada
Contributor

davidsaada commented Aug 6, 2018

Description

Add a macro for ROM end. To be used by flash related features, wishing to check whether code overlaps flash writes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-storage and geky Aug 6, 2018

@@ -28,6 +28,20 @@
#include "platform/SingletonPtr.h"
#include "platform/PlatformMutex.h"
#include "platform/NonCopyable.h"
#include <algorithm>

This comment has been minimized.

@offirko

offirko Aug 6, 2018

Contributor

may be a bit of an overkill for 'max' - consider using a small macro/inline instead

This comment has been minimized.

@davidsaada

davidsaada Aug 6, 2018

Contributor

Would agree if it was only used in the header file. However, as it is also used in the FlashIAP implementation, and assuming anyone that includes the header file would also use the FlashIAP class, then it shouldn't add any extra code.

@geky

geky approved these changes Aug 6, 2018

Looks good 👍

@offirko

offirko approved these changes Aug 6, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Aug 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

Build : SUCCESS

Build number : 2746
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7705/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 7, 2018

/morph mbed2-build

@0xc0170 0xc0170 removed the needs: CI label Aug 7, 2018

@0xc0170

0xc0170 approved these changes Aug 7, 2018

@cmonr cmonr merged commit b8727ec into ARMmbed:master Aug 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 705 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10248 cycles (+72 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 7, 2018

@davidsaada davidsaada deleted the davidsaada:david_rom_end_macro branch Aug 22, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment