Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CircularBuffer: volatile specifier removal #7727
Volatile specifier in this case it not required as we currently have all accesses
Pull request type
Only thing to worry about I can see is construction, but any execution context that invokes the constructor and then hands the buffer to another context /should/ already have its own ordering for that handover, otherwise the handover would be a race.
But this is not a "fix". It's not fixing an actual bug, and it could conceivably trip a problem in something lacking correct init synchronisation.
Build number : 2759
Build number : 2388
Aug 9, 2018
14 checks passed
Once the volatiles have gone from here, not sure it's worth noting their absence.
I think it is worth noting in the documentation of the enter/exit critical functions themselves. If you're using those functions, using ordinary variables without
@bmcdonnell-ionx The details are in the commit message (why they are being removed and what we are fixing). I found it sufficient for this case.
Build number : 2407