New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template: Feature -> functionality change #7728

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Aug 8, 2018

Description

Feature might be misinterpreted in some cases. This label should be about
functionality in backward compatible way. That means that this is either
deprecating some current one or adding new functionality.

Functionality change should cover:

  • adding/changing configuration
  • deprecating functionality
  • adding new functionality

This change would go automatically to feature release.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
PR template: Feature -> functionality change
Feature might be misinterpreted in some cases. This label should be about
functionality in backward compatible way. That means that this is either
deprecating some current one or adding new functionality.

Functionality change should cover:
- adding configuration
- deprecating functionality
- adding new functionality

This change would go automatically to feature release.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Aug 8, 2018

@cmonr

cmonr approved these changes Aug 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 8, 2018

Fine with me, but I would suggest holding off until the others get back tomorrow.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 8, 2018

@AnotherButler Also please review this

@0xc0170 0xc0170 requested a review from AnotherButler Aug 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Aug 14, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2802
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7728/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 15, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Aug 16, 2018

@cmonr cmonr merged commit 54d7623 into ARMmbed:master Aug 16, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 566 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9185 cycles (+119 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7728 from 0xc0170/fix_feature_template
PR template: Feature -> functionality change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment