New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix TX_ERROR event if corrupted msg is received for CONFIRMED request #7767

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
8 participants
@kivaisan
Contributor

kivaisan commented Aug 13, 2018

Description

When node sends a CONFIRMED message and gateway sends ACK in RX1 window but the
message gets corrupted during the transmission (e.g. MIC fails), currently
our stack already checks for retransmission after RX1 and if retries attemps are
exhausted, TX_ERROR event is sent to application. This is wrong as MAC layer
will still attempt reception in RX2 window.

This commit fixes the behaviour so that TX_ERROR is not sent until RX2 window
has been closed.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
Lora: Fix TX_ERROR event if corrupted msg is received for CONFIRMED r…
…equest

When node sends a CONFIRMED message and gateway sends ACK in RX1 window but the
message gets corrupted during the transmission (e.g. MIC fails), currently
our stack already checks for retransmission after RX1 and if retries attemps are
exhausted, TX_ERROR event is sent to application. This is wrong as MAC layer
will still attempt reception in RX2 window.

This commit fixes the behaviour so that TX_ERROR is not sent until RX2 window
has been closed.
@hasnainvirk

This comment has been minimized.

Collaborator

hasnainvirk commented on 07f4ca8 Aug 10, 2018

Looks good to me.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 13, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 13, 2018

This is fix for #7718

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Aug 20, 2018

@cmonr This needs CI. Failure is not related to the PR.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2838
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7767/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 21, 2018

/morph uvisor-test

@cmonr cmonr merged commit 36ee9b9 into ARMmbed:master Aug 21, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10238 cycles (-197 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7767 from kivaisan/fix_tx_error_if_corrupt…
…er_msg_received

Lora: Fix TX_ERROR event if corrupted msg is received for CONFIRMED request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment