New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRa: Fix MAC initialization for connection with parameters #7770

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
8 participants
@kivaisan
Contributor

kivaisan commented Aug 13, 2018

Description

LoRaMAC was not initialized properly if application called
connect(const lorawan_connect_t &connect);

This causes problems for example in case where application
first disconnects and then reconnects as counter values are not
initialized.

This fixes #7759.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
LoRa: Fix MAC initialization for connection with parameters
LoRaMAC was not initialized properly if application called
connect(const lorawan_connect_t &connect);

This causes problems for example in case where application
first disconnects and then reconnects as counter values are not
initialized.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 13, 2018

@cmonr cmonr requested a review from kjbracey-arm Aug 13, 2018

@cmonr

cmonr approved these changes Aug 13, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 13, 2018

Going to try and target this for the next patch, but it's possible this might be fixing something that's going in 5.10.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 14, 2018

Build : SUCCESS

Build number : 2784
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7770/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 14, 2018

Test failure does not seem to relate this PR. Could you please restart the test?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Aug 14, 2018

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 14, 2018

CI had an issue a few hours ago.
/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 16, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

Restarting since the test hit an issue that is now fixed in master.

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2018

@cmonr cmonr merged commit 08afaf2 into ARMmbed:master Aug 21, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 568 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9895 cycles (-169 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7770 from kivaisan/fix_rejoin_with_parameters
LoRa: Fix MAC initialization for connection with parameters
@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 23, 2018

Ended up being based off of prior changes going into 5.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment