New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix join-response failure handling #7785

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
9 participants
@kivaisan
Contributor

kivaisan commented Aug 14, 2018

Description

Thix commit fixes a bug where stack was resending join-accept already
after RX1 if received join-response was invalid.

Stack should wait for RX2 before resending the join-accept.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
Lora: Fix join-response failure handling
Thix commit fixes a bug where stack was resending join-accept already
after RX1 if received join-response was invalid.

Stack should wait for RX2 before resending the join-accept.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 14, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Aug 14, 2018

Looks good to me. +1

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2839
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7785/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 21, 2018

Could you please restart the test as I don't see this failure is related to this PR?

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 21, 2018

/morph test
/morph uvisor-test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 21, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 81f5dec into ARMmbed:master Aug 22, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10466 cycles (-88 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7785 from kivaisan/fix_join_accept_failure…
…_handling

Lora: Fix join-response failure handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment