Skip to content

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Aug 14, 2018

Description

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

This change is done in Mbed OS master in #7780

@artokin
Copy link
Contributor Author

artokin commented Aug 14, 2018

@kjbracey-arm , @SeppoTakalo , @mikter would you please review?

@adbridge
Copy link
Contributor

adbridge commented Aug 14, 2018

There is only one more patch release before 5.10 (5.9.6). We will attempt to include this PR in that. If we get any merge conflicts then it will be postponed to 5.10. NOTE this will not be directly merged.

@kjbracey
Copy link
Contributor

To make Anna's life easier, can you make this a simple commit? Don't think we need to do the subtree merge for a patch backport. I think this should do it:

git reset --keep origin/master
git cherry-pick -m 1 099120f

and then probably

git commit --amend -c 8307056

to pick up the message from the other commit.

@artokin artokin force-pushed the nsrc596 branch 2 times, most recently from 6538f5e to a10223b Compare August 14, 2018 13:42
…..3abd82e

3abd82e Merge branch 'release_internal_v8.1.1' into release_external_v8.1.1
f2ca069 Update apache license to config-files (ARMmbed#1781)
b2179ee Rename cfg-files to h-files (ARMmbed#1780)

git-subtree-dir: features/nanostack/sal-stack-nanostack
git-subtree-split: 3abd82e07a733fbb84e786f138541b5a0ef50c26
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 15, 2018

@artokin I am missing here a statement that this was tested using mbed export and fixes the problem (at least one export done to confirm this fixes the problem and there is no other issue).

@artokin
Copy link
Contributor Author

artokin commented Aug 15, 2018

@0xc0170 , I'm not able to validate this fix properly as the error occurs with online exporter and I can't test this PR there. Would you have any suggestions for the testing?

I'm not able reproduce the original error in Windows (Git bash, mbed export -i uvision -m LPC1768 and compilation with uvision5)

@cmonr
Copy link
Contributor

cmonr commented Aug 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2822
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7789/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 17, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 18, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 18, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 19, 2018

@kjbracey
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 20, 2018

Test : FAILURE

Build number : 2587
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7789/2587

@cmonr
Copy link
Contributor

cmonr commented Aug 21, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

20:30:58 /tmp/jenkins2117207875871809262.sh: line 157: echo: write error: No space left on device

Crap.

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

Other test jobs seem to still be running fine, so this might have been isolated to the particular machine.
/morph test

@cmonr
Copy link
Contributor

cmonr commented Aug 23, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 23, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 23, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 24, 2018

Integrated already, can close this one

@0xc0170 0xc0170 closed this Aug 24, 2018
@artokin artokin deleted the nsrc596 branch August 24, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants