New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TMPM64B IAR linker file #7791

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
6 participants
@davidsaada
Contributor

davidsaada commented Aug 14, 2018

Description

Remove unnecessary manual inclusion of tmpm64b_fc object file in linker script
This manual inclusion is unnecessary and causes linker issues when trying to add changes (as in #7212).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change
Fix TMPM64B IAR linker file
Remove unnecessary manual inclusion of tmpm64b_fc object file in linker script
@NirSonnenschein

looks ok to me

@davidsaada

This comment has been minimized.

Contributor

davidsaada commented Aug 15, 2018

@NirSonnenschein NirSonnenschein requested a review from dannybenor Aug 15, 2018

@dannybenor

This comment has been minimized.

dannybenor commented Aug 15, 2018

Looks good, go ahead

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 15, 2018

Hi @dannybenor , we need a technical review as part of the review process, can you please approve so we can move this into CI?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 15, 2018

Wil start CI when CI load has decreased.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 17, 2018

Build : SUCCESS

Build number : 2824
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7791/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 19, 2018

/morph uvisor-test

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 21, 2018

/morph uvisor-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 21, 2018

@cmonr cmonr merged commit fa4b2f0 into ARMmbed:master Aug 21, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10649 cycles (+95 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@davidsaada davidsaada deleted the davidsaada:david_fix_tmpm64b_iar_linker_file branch Aug 22, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7791 from davidsaada/david_fix_tmpm64b_iar…
…_linker_file

Fix TMPM64B IAR linker file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment