New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Add getters for device and serial to EasyCellularConnection #7795

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
8 participants
@mirelachirica
Contributor

mirelachirica commented Aug 15, 2018

Description

Addresses need to have direct access from application to power interface:
#7470 (comment)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 20, 2018

@0xc0170 0xc0170 changed the title from Cellular: Added getters for device and serial to EasyCellularConnection to Cellular: Add getters for device and serial to EasyCellularConnection Aug 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

@wajahat-ublox Please review

@wajahat-ublox

This comment has been minimized.

wajahat-ublox commented Aug 27, 2018

Looks good as this will resolve the problem of not having access to AT_CellularPower::opt_power_save_mode

Sorry for late response, i was on vacations.

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Aug 27, 2018

@0xc0170 Can you trigger this build? We would like to make it in 5.10.0-rc1

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2918
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

Something hung up the export test. Restarting.

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

Will restart once CI load is lower...

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 28, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 29, 2018

/morph test

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 29, 2018

CI seems to have passed, but missing a review @0xc0170

@cmonr cmonr merged commit 7b29f7d into ARMmbed:master Aug 29, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10063 cycles (-228 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

chuanga added a commit to chuanga/wise-1570-simple-mbed-cloud-client that referenced this pull request Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment