Skip to content

Cellular: Add getters for device and serial to EasyCellularConnection #7795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

mirelachirica
Copy link
Contributor

Description

Addresses need to have direct access from application to power interface:
#7470 (comment)

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x ] Feature
[ ] Breaking change

@0xc0170 0xc0170 changed the title Cellular: Added getters for device and serial to EasyCellularConnection Cellular: Add getters for device and serial to EasyCellularConnection Aug 20, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 20, 2018

@wajahat-ublox Please review

@wajahat-abbas
Copy link
Member

Looks good as this will resolve the problem of not having access to AT_CellularPower::opt_power_save_mode

Sorry for late response, i was on vacations.

@AnttiKauppila
Copy link

@0xc0170 Can you trigger this build? We would like to make it in 5.10.0-rc1

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2918
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7795/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

Something hung up the export test. Restarting.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 27, 2018

Will restart once CI load is lower...

@mbed-ci
Copy link

mbed-ci commented Aug 27, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 28, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 29, 2018

@NirSonnenschein
Copy link
Contributor

CI seems to have passed, but missing a review @0xc0170

@cmonr cmonr merged commit 7b29f7d into ARMmbed:master Aug 29, 2018
chuanga added a commit to chuanga/wise-1570-simple-mbed-cloud-client that referenced this pull request Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants