Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Change visibility of LoRaMac internal methods as private #7839

Merged
merged 1 commit into from Aug 24, 2018
Merged

Lora: Change visibility of LoRaMac internal methods as private #7839

merged 1 commit into from Aug 24, 2018

Conversation

kivaisan
Copy link
Contributor

Description

Some LoRaMac methods were defined as public even though there were used only
internally.

Also removed definition of some methods which were not even implemented nor used.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Some LoRaMac methods were defined as public even though there were used only
internally.

Also removed definition of some methods which were not even implemented nor used.
@kivaisan
Copy link
Contributor Author

@AnttiKauppila @hasnainvirk please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

Build : SUCCESS

Build number : 2855
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7839/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 21, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 24, 2018

@kjbracey-arm Mind taking a quick look at this so that we can wrap up the PR? It's even ready to be merged assuming it's all good!

@0xc0170 0xc0170 merged commit 781573a into ARMmbed:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants