New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lora: Change visibility of LoRaMac internal methods as private #7839
Lora: Change visibility of LoRaMac internal methods as private #7839
Conversation
Some LoRaMac methods were defined as public even though there were used only internally. Also removed definition of some methods which were not even implemented nor used.
@AnttiKauppila @hasnainvirk please review. |
/morph build |
Build : SUCCESSBuild number : 2855 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2485 |
Test : SUCCESSBuild number : 2614 |
@kjbracey-arm Mind taking a quick look at this so that we can wrap up the PR? It's even ready to be merged assuming it's all good! |
Description
Some LoRaMac methods were defined as public even though there were used only
internally.
Also removed definition of some methods which were not even implemented nor used.
Pull request type