New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Change visibility of LoRaMac internal methods as private #7839

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
8 participants
@kivaisan
Contributor

kivaisan commented Aug 21, 2018

Description

Some LoRaMac methods were defined as public even though there were used only
internally.

Also removed definition of some methods which were not even implemented nor used.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Lora: Change visibility of LoRaMac internal methods as private
Some LoRaMac methods were defined as public even though there were used only
internally.

Also removed definition of some methods which were not even implemented nor used.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Aug 21, 2018

@AnttiKauppila @hasnainvirk please review.

@0xc0170 0xc0170 requested a review from AnttiKauppila Aug 21, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 21, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 21, 2018

Build : SUCCESS

Build number : 2855
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7839/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2018

@0xc0170 0xc0170 requested a review from kjbracey-arm Aug 22, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 24, 2018

@kjbracey-arm Mind taking a quick look at this so that we can wrap up the PR? It's even ready to be merged assuming it's all good!

@0xc0170 0xc0170 merged commit 781573a into ARMmbed:master Aug 24, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10159 cycles (-102 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 29, 2018

Merge pull request ARMmbed#7839 from kivaisan/change_loramac_internal…
…_methods_as_private

Lora: Change visibility of LoRaMac internal methods as private
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment