New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIMXRT1050: Fix I2C Byte transfer functions #7843

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Aug 21, 2018

Description

  1. Added a flag to issue START command
  2. Do not send START command inside i2c_start function as the LPI2C hardware will issue a STOP on reception of a NACK
  3. Remove the i2c_address global variable, this is not required

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
MIMXRT1050: Fix I2C Byte transfer functions
1. Added a flag to issue START command
2. Do not send START command inside i2c_start function as
   the LPI2C hardware will issue a STOP on reception
   of a NACK
3. Remove the i2c_address global variable, this is not
   required

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Aug 21, 2018

@cmonr cmonr requested review from cmonr and 0xc0170 Aug 22, 2018

@cmonr cmonr added the needs: review label Aug 22, 2018

@cmonr

LGTM, just a question.

kLPI2C_MasterDataMatchFlag);
/* Turn off auto-stop option. */
base->MCFGR1 &= ~LPI2C_MCFGR1_AUTOSTOP_MASK;

This comment has been minimized.

@cmonr

cmonr Aug 22, 2018

Contributor

Is this ever turned on again, or is it simply not needed anymore?

This comment has been minimized.

@mmahadevan108

mmahadevan108 Aug 22, 2018

Contributor

It is not needed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 22, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Aug 22, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 22, 2018

Build : SUCCESS

Build number : 2859
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7843/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit cb8d09a into ARMmbed:master Aug 23, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 584 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10055 cycles (-173 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:MXRT_Fix_I2C_Byte_Transfer branch Aug 24, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 29, 2018

Merge pull request ARMmbed#7843 from codeauroraforum/MXRT_Fix_I2C_Byt…
…e_Transfer

MIMXRT1050: Fix I2C Byte transfer functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment