New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Make AT_CellularStack socket array multi-thread safe #7857

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
7 participants
@AriParkkila
Contributor

AriParkkila commented Aug 22, 2018

Description

The socket array _sockets was not multi-thread safe. That could be a problem if two threads try to open socket at the same.

In socket_close() was delete socket called erroneously before calling socket_close_impl, that may still use that socket.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 22, 2018

@mirelachirica please review

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 22, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 23, 2018

@jarvte

Declaration of _socket_mutex is ifdef'd but not it's usage. Remove #ifdef or add them also where it's used.

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Aug 23, 2018

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-stack-mt branch from 6ecfcd0 to 4b223b6 Aug 24, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 24, 2018

@jarvte please review

@jarvte

jarvte approved these changes Aug 24, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 27, 2018

Build : SUCCESS

Build number : 2916
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7857/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 686b779 into ARMmbed:master Aug 27, 2018

15 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 585 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10464 cycles (+369 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@AriParkkila AriParkkila deleted the AriParkkila:cell-stack-mt branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment