Skip to content

DO NOT MERGE - Mbed TLS update RC1 #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

k-stachowiak
Copy link
Contributor

Description

This PR imports a release candidate of the Mbed TLS library

Please DO NOT MERGE it. It has been raised in order for the CI to have a run at it.

@cmonr
Copy link
Contributor

cmonr commented Aug 30, 2018

Welp, let's put it in the queue and hope for the best!

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 30, 2018

Build : FAILURE

Build number : 2968
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7940/

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

Please review the build failures (most of them I checked fail with mbedtls_aes_crypt_ofb undefined)

@k-stachowiak
Copy link
Contributor Author

I'm on it. @yanesca from the crypto team has proposed a solution that I am now testing locally. I will update the PR as soon as I get a basic test done on my machine.

@k-stachowiak
Copy link
Contributor Author

I have pushed the change suggested by the crypto team. It built and ran on my local setup, but I don't have a way to test it against the failing targets, so let's see, how the failing boards do in the CI now.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

Build : SUCCESS

Build number : 2972
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7940/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

One of the failures "NUCLEO_F767ZI_make_iar/sources/examples/mbed-os-example-mesh-minimal/main.cpp",39 Fatal error[Pe1696]: cannot open source file "NanostackRfPhyAtmel.h"

most of them I checked are regarding this mesh minimal example. Not certain how is it related to the changes here? Please review

@SeppoTakalo is reviewing, will update

@k-stachowiak
Copy link
Contributor Author

@sbutcher-arm @yanesca Could you please check if this may be induced by Mbed TLS changes? I'm already out of office, so I just briefly looked at the issue, and don't see a direct connection with our library.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

@sbutcher-arm @yanesca Could you please check if this may be induced by Mbed TLS changes? I'm already out of office, so I just briefly looked at the issue, and don't see a direct connection with our library.

@SeppoTakalo Is this an example issue not related to this PR, so will be fixed separately and this rerun?

@SeppoTakalo
Copy link
Contributor

I have broken the exported builds while preparing applications to #7814

So this will be fixed once that is in.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2018

Note : only exporters are affect, testing in progress. We will restart exporters once connectivity is in.

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

@oliverjharper
Copy link

@0xc0170 I see ci-morph-test job has failed but test report appears OK, can you confirm?

@cmonr
Copy link
Contributor

cmonr commented Aug 31, 2018

@oliverjharper We've been seeing these sync issues all over the place.

@cmonr
Copy link
Contributor

cmonr commented Sep 1, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 1, 2018

@NirSonnenschein
Copy link
Contributor

@0xc0170 @cmonr this seems to have passed the tests but there is an exporter failure.

@cmonr
Copy link
Contributor

cmonr commented Sep 1, 2018

@SeppoTakalo #7940 (comment)

Does this mean CI needs to be rerun, or does the PR need to be updated first?

@SeppoTakalo
Copy link
Contributor

@cmonr Re-running exporters should be enough, as I just touched the example applications, and by doing that I broke all others than #7814.

I don't see the need of full re-test.

@cmonr
Copy link
Contributor

cmonr commented Sep 2, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants