New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix missing updates sent callback in GattServer using Cordio stack #7981

Merged
merged 2 commits into from Sep 18, 2018

Conversation

Projects
None yet
5 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Sep 4, 2018

Description

Calling onDataSent registers a callback to be notified of updates sent. Cordio implementation of the GattServer doesn't call this callback. This adds the call.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm changed the title from BLE: added missing callback to cordio after updates are sent to BLE: fix missing updates sent callback in GattServer using Cordio stack Sep 4, 2018

@paul-szczepanek-arm paul-szczepanek-arm requested review from pan- and donatieng Sep 4, 2018

@paul-szczepanek-arm paul-szczepanek-arm force-pushed the paul-szczepanek-arm:ondatasent branch from b536572 to ec373c2 Sep 4, 2018

@pan-

The write overload should be modified too:

if (is_update_authorized(connection, att_handle)) {
uint16_t cccEnabled = AttsCccEnabled(connection, cccd_index);
if (cccEnabled & ATT_CLIENT_CFG_NOTIFY) {
AttsHandleValueNtf(connection, att_handle, len, (uint8_t*)buffer);
}
if (cccEnabled & ATT_CLIENT_CFG_INDICATE) {
AttsHandleValueInd(connection, att_handle, len, (uint8_t*)buffer);
}
}

@0xc0170 0xc0170 added the needs: work label Sep 4, 2018

@paul-szczepanek-arm

This comment has been minimized.

Member

paul-szczepanek-arm commented Sep 4, 2018

@pan- fixed

@pan-

pan- approved these changes Sep 4, 2018

@0xc0170

0xc0170 approved these changes Sep 6, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 17, 2018

Build : SUCCESS

Build number : 3084
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7981/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 18, 2018

@cmonr cmonr merged commit c3128cd into ARMmbed:master Sep 18, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10295 cycles (+23 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment