New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to CMSIS defines for Non-Secure #8025

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
7 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Sep 6, 2018

Description

CMSIS updated the __DOMAIN_NS define to DOMAIN_NS. Update the define in existing code for non-secure part.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

CC @gaborkertesz @ccli8

@ccli8

ccli8 approved these changes Sep 7, 2018

@deepikabhavnani That's OK.

@0xc0170

0xc0170 approved these changes Sep 7, 2018

@0xc0170 0xc0170 added the needs: CI label Sep 7, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 7, 2018

M2351 is still in staging CI, wait for 5.10 release to test this PR.
@gaborkertesz - Can you verify locally if this fix works (https://github.com/ARMmbed/mbed-os/pull/8025/files#diff-9cf75aea879b6b9cc5026af0b8f708a3L429) for Musca as well?

@gaborkertesz

This comment has been minimized.

Contributor

gaborkertesz commented Sep 10, 2018

ARMC6 is working for Musca-A1 (after updating to this change in platform files). Please update GCC as well!

@kjbracey-arm kjbracey-arm added needs: work and removed needs: CI labels Sep 10, 2018

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Sep 10, 2018

Merge conflict - needs rebasing

Align to CMSIS defines for Non-secure
CMSIS updated the __DOMAIN_NS define to DOMAIN_NS. Update the define
in existing code for non-secure part.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:flag_update branch from 4d98ad8 to ff80e29 Sep 10, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 10, 2018

Rebased and updated for GCC as well.

@gaborkertesz

This comment has been minimized.

Contributor

gaborkertesz commented Sep 10, 2018

GCC update has been tested and works as expected for Musca-A1.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 17, 2018

@ARMmbed/mbed-os-maintainers - Consider this as high priority for Musca.
@studavekar - Can we test this PR in staging as well for Nuvoton?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3099
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8025/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Sep 19, 2018

@0xc0170 0xc0170 merged commit 81d0948 into ARMmbed:master Sep 19, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9831 cycles (-710 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:flag_update branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment