New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the reported SNR from unsigned to signed. #8034

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
8 participants
@EnsilicaEdd
Contributor

EnsilicaEdd commented Sep 7, 2018

The rx metadata API returns the SNR of the received data. It's logically a signed value (since LoRa allows the signal to be below the noise floor, the SNR may be negative), and is signed within the stack.
But as it makes its way up the reporting chain, it becomes unsigned. I suspect this is not intentional, so I have simply changed the unsigned type to signed.

Aside: This is an unsolicited Pull Request without an associated Issue. I don't know whether this is acceptable etiquette, so please let me know if not.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Changed the reported SNR from unsigned to signed.
Internally and logically it is a signed value.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Sep 7, 2018

@hasnainvirk

Awesome. Looks good.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 12, 2018

@cmonr needs CI here. Minor change, should get in as fast as possible.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

@EnsilicaEdd Thanks for the fix. We will start CI once we complete 5.10.1 release (within a day).

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 20, 2018

Aside: This is an unsolicited Pull Request without an associated Issue. I don't know whether this is acceptable etiquette, so please let me know if not.

@EnsilicaEdd If there's a verified issue, PRs tend to get more attention, but submitting a PR without one is fine.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3148
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8034/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 24, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Sep 25, 2018

@0xc0170 0xc0170 merged commit a999289 into ARMmbed:master Sep 25, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10586 cycles (+1514 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@EnsilicaEdd EnsilicaEdd deleted the EnsilicaEdd:snr_unsigned_signed branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment