New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix ADRAckReq #8054

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
8 participants
@kivaisan
Contributor

kivaisan commented Sep 10, 2018

Description

This commit fixes two bugs related to ADRAckReq:

  • adr_ack_counter must be incremented for all uplink messages (not just confirmed)
  • When ADR_ACK_LIMIT + ADR_ACK_DELAY has been reached, stack decreased used
    datarate twice.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 10, 2018

Lora: Fix ADRAckReq
This commit fixes two bugs related to ADRAckReq:
- adr_ack_counter must be incremented for all uplink messages (not just confirmed)
- When ADR_ACK_LIMIT + ADR_ACK_DELAY has been reached, stack decreased used
  datarate twice.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3105
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8054/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 19, 2018

@0xc0170 0xc0170 merged commit d8ec21a into ARMmbed:master Sep 19, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9165 cycles (-1376 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment