New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cellular PIN code print from debug log. #8057

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
7 participants
@korjaa
Contributor

korjaa commented Sep 10, 2018

Description

Removed cellular PIN code print from debug log.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from TeemuKultala and AriParkkila Sep 10, 2018

@cmonr cmonr added the needs: review label Sep 10, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Sep 11, 2018

Can you explain a reason for this? I guess security might be your concern, but that's not a very valid point here because in R&D developer already knows PIN and in production builds debug prints are not enabled.

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Sep 17, 2018

@korjaa this change is OK, but I'd like to understand if you can explain some reason for this?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Sep 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

@korjaa Any update or should be closed ?

@AriParkkila

This is as per Security Requirements: Sensitive data must not be logged.

@korjaa

This comment has been minimized.

Contributor

korjaa commented Sep 25, 2018

Sorry, I've been only monitoring the JIRA ticket. I still think this needs to go in and I will close the JIRA ticket when this is merged.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 25, 2018

@korjaa korjaa force-pushed the korjaa:remove_sim_pin_print branch from aea7c8a to 473ac20 Oct 1, 2018

@korjaa

This comment has been minimized.

Contributor

korjaa commented Oct 1, 2018

rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3218
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8057/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 6, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit b153bb3 into ARMmbed:master Oct 8, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(-32 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10238 cycles (+245 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment