Signature to track memory allocations by wrapper functions #8062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
requested review from
0xc0170 and
a team
and removed request for
0xc0170
deepikabhavnani
force-pushed
the
heap_fix_7912
branch
from
cf22ce9 to
f949892
Compare
|
@ccli8 @cyliangtw - Please review |
ccli8
approved these changes
Sep 13, 2018
cyliangtw
approved these changes
Sep 13, 2018
c1728p9
approved these changes
Sep 14, 2018
0xc0170
approved these changes
Sep 24, 2018
|
/morph build |
Build : SUCCESSBuild number : 3226 Triggering tests/morph test |
Test : SUCCESSBuild number : 3029 |
|
/morph export-build |
Exporter Build : ABORTEDBuild number : 2814 |
|
/morph export-build |
Exporter Build : FAILUREBuild number : 2821 |
|
Please rebase, will restart testing |
added 2 commits
October 8, 2018 07:37
malloc guarantees aligned memory. If we add an alignment here, we are adding additonal unused 4 bytes. Each allocator has its own 4/8 byte header (GGC / ARM have 4 bytes). So if user request for 8 bytes of memory stats will add 8 + allocator 8. However if we remove the alignment in stats header, allocator will consider add 4 bytes to 12 byte request and zero padding. It will be beneficial to leave the padding to allocator.
Compilers allocate some section of memory without using wrapper function, which is later freed when wrappers were initialized. Since the allocated memory didn;t contain wrapper header the pointer got corrupt when calling to free. This implementation of signature addition during malloc and signature check during free helps in freeing the memory allocated by wrapper functions properly and also the internal memory allocated by compilers (without malloc wrappers).
deepikabhavnani
force-pushed
the
heap_fix_7912
branch
from
f949892 to
0e75879
Compare
@0xc0170 - Rebase done. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compilers allocate some section of memory without using wrapper function, which is later freed when wrappers were initialized. Since the allocate memory didn;t contain wrapper header the pointer got corrupt when calling to free.
This implementation of signature addition during malloc and signature check during free helps in freeing the memory allocated by wrapper functions properly and also the internal memory allocated by compilers (without malloc wrappers).
Resolves: #7912
Pull request type