New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Refactoring compliance test code #8074

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
7 participants
@hasnainvirk
Contributor

hasnainvirk commented Sep 11, 2018

Description

While performing compliance tests with an industry tester, we realized
that there was no need for any extra handling code for the compliance
tests. The tests would run fine, if we only have a handling application.
However, in normal operation we wouldn't like the network to send us any
traffic on compliance testing port. To mitigate that, on the reception
path we filter out any traffic on compliance testing port if compliance
testing is not underway. User should define LORAWAN_COMPLIANCE_TEST macro
in mbed_app.json to enable traffic on compliance test port.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Target

5.10.1

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 11, 2018

@AnttiKauppila @kivaisan Please review.

tr_debug("TX: Channel=%d, DR=%d", _params.channel, next_channel.current_datarate);
uint8_t dr_offset = _lora_phy->apply_DR_offset(_params.sys_params.channel_data_rate,
uint8_t rx_dr = _lora_phy->apply_DR_offset(_params.sys_params.channel_data_rate,

This comment has been minimized.

@kivaisan

kivaisan Sep 11, 2018

Contributor

Please rename to rx1_dr because this is RX1 specific.

_params.sys_params.rx1_dr_offset);
_lora_phy->compute_rx_win_params(dr_offset, MBED_CONF_LORA_DOWNLINK_PREAMBLE_LENGTH,
tr_debug("TX: Channel=%d, TX DR=%d, RX DR=%d",

This comment has been minimized.

@kivaisan

kivaisan Sep 11, 2018

Contributor

Maybe RX DR should be also changed as "RX1 DR"

#if defined(LORAWAN_COMPLIANCE_TEST)
lorawan_status_t LoRaWANStack::send_compliance_test_frame_to_mac()
lorawan_status_t LoRaWANStack::fetch_current_session_info(lorawan_session_t &session)

This comment has been minimized.

@kivaisan

kivaisan Sep 11, 2018

Contributor

This probably should not be part of this PR?

@hasnainvirk hasnainvirk force-pushed the hasnainvirk:compliance_testing branch from 883f856 to 0135ea0 Sep 11, 2018

LoRaWAN: Refactoring compliance test code
While performing compliance tests with an industry tester, we realized
that there was no need for any extra handling code for the compliance
tests. The tests would run fine, if we only have a handling application.
However, in normal operation we wouldn't like the network to send us any
traffic on compliance testing port. To mitigate that, on the reception
path we filter out any traffic on compliance testing port if compliance
testing is not underway. User should define LORAWAN_COMPLIANCE_TEST macro
in mbed_app.json to enable traffic on compliance test port.

@hasnainvirk hasnainvirk force-pushed the hasnainvirk:compliance_testing branch from 0135ea0 to e110856 Sep 11, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 11, 2018

@kivaisan Please review again especially the method is_port_valid().

@kivaisan

Looks good

@cmonr

cmonr approved these changes Sep 11, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 14, 2018

@hasnainvirk Once we are into OOB for a minor release, only Critical or Blocking bugs found are generally considered for inclusion. There may be exceptions but that is the general policy. This however is a generic fix which is neither and thus can wait for 5.10.1.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3109
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8074/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 20, 2018

time_start error in test runner. Retesting.

/morph test

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 20, 2018

@cmonr Failure not related to this PR.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 20, 2018

@0xc0170 0xc0170 merged commit f3af826 into ARMmbed:master Sep 20, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9084 cycles (-1457 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment