New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 L0 ADC internal channel fix #8103

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
6 participants
@jeromecoutant
Contributor

jeromecoutant commented Sep 12, 2018

Description

2 issues about ADC internal channels :

  • channel definition was wrong for STM32L072 targets in PinMap_ADC_Internal structure
  • Temperature sensor needs some longer stabilization time before reading the value

Manual internal tests have been performed in order to validate the correction.

Thx

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

jeromecoutant added some commits Sep 12, 2018

STM32L0 internal channel ADC_TEMP
Temperature measurement was not stable

@cmonr cmonr added the needs: review label Sep 12, 2018

@cmonr cmonr requested a review from ARMmbed/team-st-mcd Sep 12, 2018

@bcostm

bcostm approved these changes Sep 13, 2018

@@ -172,6 +172,12 @@ uint16_t adc_read(analogin_t *obj)

HAL_ADC_ConfigChannel(&obj->handle, &sConfig);

/* need to wait for some stabilization time after setting the TSEN bit in the ADC_CCR

This comment has been minimized.

@bcostm

bcostm Sep 17, 2018

Contributor

This wait is not needed on other STM32 series ?

@bcostm

bcostm approved these changes Sep 17, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 1, 2018

Build : SUCCESS

Build number : 3200
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8103/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

Test stage will be restarted after 5.10.1 RC + exporters

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 3, 2018

Build : SUCCESS

Build number : 3228
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8103/

Triggering tests

/morph test
/morph mbed2-build

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 4, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 0b1bc87 into ARMmbed:master Oct 5, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9137 cycles (+88 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 5, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_L0_ADC branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment