Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change update file format to binary for all targets #8167

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Change update file format to binary for all targets #8167

merged 1 commit into from
Oct 8, 2018

Conversation

JammuKekkonen
Copy link
Contributor

Description

  • Change the default file format to binary for all targets, even though some targets need hex as app format, updater always needs bin
  • Unify the file name from generator side and usage side for the update bin

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Change update file format to binary to all targets
49572d5 
- Change the default file format to binary for all targets, even though some targets need hex as app format, updater always needs bin for now
- Unify the file name generation from generator side and usage side for the update bin
@JammuKekkonen
Copy link
Contributor Author

@yogpan01
@teetak01

@0xc0170 0xc0170 requested a review from a team September 18, 2018 09:39
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

While @cmonr is away, @theotherjimmy can you review?

@yogpan01
Copy link
Contributor

yogpan01 commented Oct 1, 2018

Approved.
@cmonr @0xc0170 This PR fixes https://jira.arm.com/browse/IOTCORE-450 issue.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

Thanks for the reference, helps!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3252
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8167/

Triggering tests

/morph test
/morph mbed2-build

@studavekar
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2853
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8167/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : SUCCESS

Build number : 2856
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8167/

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Test : SUCCESS

Build number : 3059
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8167/3059

@cmonr cmonr merged commit 43cf16d into ARMmbed:master Oct 8, 2018
@JammuKekkonen JammuKekkonen deleted the change_update_format_to_binary branch October 9, 2018 06:02
@teetak01 teetak01 mentioned this pull request Jan 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@yogpan01 yogpan01 Awaiting requested review from yogpan01

@teetak01 teetak01 Awaiting requested review from teetak01

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@JammuKekkonen @0xc0170 @yogpan01 @mbed-ci @studavekar @theotherjimmy @cmonr @NirSonnenschein