New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change update file format to binary for all targets #8167

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
8 participants
@JammuKekkonen
Contributor

JammuKekkonen commented Sep 18, 2018

Description

  • Change the default file format to binary for all targets, even though some targets need hex as app format, updater always needs bin
  • Unify the file name from generator side and usage side for the update bin

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Change update file format to binary to all targets
- Change the default file format to binary for all targets, even though some targets need hex as app format, updater always needs bin for now
- Unify the file name generation from generator side and usage side for the update bin
@JammuKekkonen

This comment has been minimized.

Contributor

JammuKekkonen commented Sep 18, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Sep 18, 2018

@0xc0170 0xc0170 requested review from yogpan01 and teetak01 Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

While @cmonr is away, @theotherjimmy can you review?

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

Thanks for the reference, helps!

@0xc0170

0xc0170 approved these changes Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 5, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3252
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8167/

Triggering tests

/morph test
/morph mbed2-build

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 43cf16d into ARMmbed:master Oct 8, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 599 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10238 cycles (+1103 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

@JammuKekkonen JammuKekkonen deleted the JammuKekkonen:change_update_format_to_binary branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment