New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: fix wrong LSE config in serial_baud function #8187

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
6 participants
@bcostm
Contributor

bcostm commented Sep 19, 2018

Description

The LSE configuration was incorrectly done in serial_baud function.

Fixes #8110

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Sep 19, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 19, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 20, 2018

Might need to get this into 5.10.1 as it could be related to one of the client issues. (IOTHAL-356)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

Is this fixes the error: Cannot initialize RTC with LSE ?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 20, 2018

@adbridge It's unknown if it's able to correct the IOTHAL issue, since they're no longer able to reproduce the issue.

Will bring it in asap anyways, since RTC issues tend to be persistent across reflashes and can cause havoc on CI.

/morph build

FYI @ARMmbed/mbed-os-test

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3117
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8187/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 21, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 21, 2018

@0xc0170 0xc0170 merged commit 54afd1c into ARMmbed:master Sep 21, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 609 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9843 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@bcostm bcostm deleted the bcostm:fix_serial_lse branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment