New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust stack & heap for IAR on STM32F412xG #8225

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
6 participants
@juhoeskeli
Contributor

juhoeskeli commented Sep 24, 2018

Description

Adjusted IAR Heap to 84kB and stack to 1kB

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change
@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Sep 24, 2018

@juhoeskeli Hi - could you provide more insights why you need such a size increase ?

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Sep 24, 2018

@juhoeskeli

This comment has been minimized.

Contributor

juhoeskeli commented Sep 24, 2018

@LMESTM Hello!
It seems with the latest cloud client RC with current mbed-os master we are consuming more heap than is available on targets with this MCU. It would be of course good to know why this is so, but I think it is a separate task.

For reference STM32F411xE has identical configuration that I am proposing in this PR.

@LMESTM

This comment has been minimized.

Contributor

LMESTM commented Sep 24, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

Stack alignment is ongoing effort (#7238). @bulislaw / @mprse what about the heap size?

@jeromecoutant

Hi
From test result point of view, all was OK during night test with NUCLEO_F412ZG and IAR

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 1, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

Reference (the issue related to the stack and heap) : #4067.

@0xc0170

0xc0170 approved these changes Oct 1, 2018

For reference STM32F411xE has identical configuration that I am proposing in this PR.

As requested, there should be stack/heap definition for IAR. I referenced above the related issue. This PR is fine but not ideal solution to the problem.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 1, 2018

@juhoeskeli

This comment has been minimized.

Contributor

juhoeskeli commented Oct 2, 2018

I agree it is not ideal, but can we go forward like this in the short time?

@juhoeskeli

This comment has been minimized.

Contributor

juhoeskeli commented Oct 8, 2018

To next patch release, please.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3283
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8225/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 7c1cdc8 into ARMmbed:master Oct 9, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9125 cycles (-1104 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment