Skip to content

PR template: add "docs update" #8237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2018
Merged

PR template: add "docs update" #8237

merged 2 commits into from
Oct 12, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 25, 2018 •
edited
Loading

Description

This type should define changes only to documentation. This depends on the documentation update that I'll reference shortly here.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
PR template: add "docs update"
aac58a7 
As we know have documentation in the repository, this type should define changes
only to documentation.
@0xc0170 0xc0170 requested a review from a team September 25, 2018 08:43
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

Depends on ARMmbed/mbed-os-5-docs#746

@adbridge
Copy link
Contributor

What about adding, 'Tests only' ?

@0xc0170
PR template: add "test update"
a88ed6e 
Adding new test case, test unit or just updating tests
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

What about adding, 'Tests only' ?

Both PR updated

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

Should fix #7859

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 25, 2018

The current format

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Sep 25, 2018

Dunno if it makes sense to add 'only' to both new fields, or if that's suppose to be implied by the 'only select one' criteria.

@kjbracey kjbracey mentioned this pull request Oct 8, 2018
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 11, 2018

Documentation PR integrated, we should be ready for CI with this one

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Build : SUCCESS

Build number : 3326
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8237/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Exporter Build : SUCCESS

Build number : 2960
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8237/

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Test : SUCCESS

Build number : 3135
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8237/3135

@cmonr cmonr merged commit 61a626c into ARMmbed:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

+1 more reviewer

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @adbridge @cmonr @mbed-ci @paul-szczepanek-arm