New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WIFI_CONNECT_PARAMS_CHANNEL_FAIL testcase. #8241

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
6 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Sep 25, 2018

Description

Test case was assuming that secure and unsecure SSID were on different
channels.
This is not a requirement and it should be OK to run on same channel.

Fixed the testcase by using +1 on channel number to get a wrong channel.

Fixes #8227

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Fix WIFI_CONNECT_PARAMS_CHANNEL_FAIL testcase.
Test case was assuming that secure and unsecure SSID were on different
channels.
This is not a requirement and it should be OK to run on same channel.

Fixed the testcase by using +1 on channel number to get a wrong channel.
@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Sep 25, 2018

@VeijoPesonen Please review.

@0xc0170 0xc0170 requested a review from VeijoPesonen Sep 25, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Sep 26, 2018

@0xc0170 Reviewed by Veijo.
Please remove the "Needs: review" label and add "Needs: CI" and then start the test.

Thanks.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 26, 2018

Build : SUCCESS

Build number : 3167
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8241/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 27, 2018

7:18:11 mbedgt: exporting to JUNIT file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/LPC546XX/toolchain/GCC_ARM/test_report_LPC546XX-GCC_ARM.xml'...
17:18:11 mbedgt: exporting to HTML file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/LPC546XX/toolchain/GCC_ARM/test_report_LPC546XX-GCC_ARM.html'...
17:18:11 mbedgt: unexpected error:
17:18:11 'time_start'

@0xc0170 failure seems to occur while writing a test report. Would you please restart the test job.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

Will restart the job once few jobs complete

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3261
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8241/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 7, 2018

/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 15879f5 into ARMmbed:master Oct 8, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 613 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9252 cycles (-645 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

@SeppoTakalo SeppoTakalo deleted the SeppoTakalo:fix_wifi_connect_params_fail branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment