New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align MBRBlockDevice writes to underlying BlockDevice write size #8262

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
7 participants
@juhoeskeli
Contributor

juhoeskeli commented Sep 26, 2018

Description

When writing MBR the write buffer was allocated such that it would not align with BlockDevice write size resulting in failure of the write operation.

It would happen here:
err = bd->program(buffer, 512-buffer_size, buffer_size);

Now the buffer_size is calculated so that the writes will be properly aligned.

Tested with STM32L486 using internal flash as storage. Without fix it is not possible to initialise partition in the internal flash.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from geky and ARMmbed/mbed-os-storage Sep 27, 2018

@cmonr cmonr added the needs: review label Sep 27, 2018

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Sep 27, 2018

To next patch release, please.

@geky

geky approved these changes Sep 27, 2018

This looks perfect to me 👍
Thanks for this

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Sep 27, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3184
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8262/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 28, 2018

sigh

/morph test

@mbed-ci

This comment has been minimized.

@NirSonnenschein NirSonnenschein merged commit f1587b5 into ARMmbed:master Sep 28, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 625 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10210 cycles (+327 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment