Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upSTM32: Fix I2C stop condition #8280
Conversation
bcostm
referenced this pull request
Sep 28, 2018
Closed
NUCLEO_H743ZI: Fix I2C stop condition issue #11
0xc0170
added
the
needs: review
label
Oct 1, 2018
0xc0170
added
needs: CI
and removed
needs: review
labels
Oct 1, 2018
This comment has been minimized.
This comment has been minimized.
|
/morph build |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 7, 2018
Build : SUCCESSBuild number : 3270 Triggering tests/morph test |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 7, 2018
Exporter Build : SUCCESSBuild number : 2892 |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 7, 2018
Test : SUCCESSBuild number : 3078 |
NirSonnenschein
added
ready for merge
and removed
needs: CI
labels
Oct 7, 2018
cmonr
added
the
release-version: 5.10.2
label
Oct 8, 2018
cmonr
merged commit 8fd9944
into
ARMmbed:master
Oct 8, 2018
15 checks passed
ci-morph-build
build completed
Details
ci-morph-exporter
build completed
Details
ci-morph-mbed2-build
build completed
Details
ci-morph-test
test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head
This commit looks good
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test
Success
Details
jenkins-ci/unittests
Success
Details
travis-ci/astyle
Passed, 626 files
Details
travis-ci/docs
Local docs testing has passed
Details
travis-ci/events
Passed, runtime is 9879 cycles (-587 cycles)
Details
travis-ci/gitattributestest
Local gitattributestest testing has passed
Details
travis-ci/licence_check
Local licence_check testing has passed
Details
travis-ci/littlefs
Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7
Local tools-py2.7 testing has passed
Details
cmonr
removed
the
ready for merge
label
Oct 8, 2018
bcostm
deleted the
bcostm:fix_i2c_stop
branch
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bcostm commentedSep 28, 2018
Description
Need to ensure the transmission has been started before sending a STOP condition. Issue found with ci-test shield I2C test when a high frequency system clock is in used.
Tested OK on the following NUCLEO boards + all toolchains: F091, F103, F207, F303, F446, F767, L073, L152, L476
Pull request type