BLE: fix use of invalid cccd index #8318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-szczepanek-arm
changed the title
paul-szczepanek-arm
changed the title
|
|
||
| // return if the update does not have to be propagated to peers | ||
| if (local_only || !has_cccd(att_handle)) { | ||
| if (local_only || !get_cccd_index_by_value_handle(att_handle, cccd_index)) { |
There was a problem hiding this comment.
this call makes the cccd_index valid in this scope
| // Check to see if this is a CCCD | ||
| uint8_t cccd_index; | ||
| if (get_cccd_id(att_handle, cccd_index)) { | ||
| if (get_cccd_index_by_cccd_handle(att_handle, cccd_index)) { |
There was a problem hiding this comment.
the cccd_index is only valid within the scope of the if statement
pan-
approved these changes
Oct 3, 2018
0xc0170
approved these changes
Oct 4, 2018
|
/morph build |
Build : SUCCESSBuild number : 3233 Triggering tests/morph test |
|
License issue for IAR /morph mbed2-build |
Test : SUCCESSBuild number : 3036 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2830 |
0xc0170
added
ready for merge
release-version: 5.10.1
and removed
needs: CI
release-version: 5.10.2
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an error in gatt server where the cccd index variable was being used outside of its valid scope. This fix updates the variable to its correct value in the outside scope.
I also renamed the functions to explicitly state what they do to avoid ambiguity. There index is the same but the handle used to get it is different. This is now reflected in the names.
Pull request type