New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for TOSHIBA TMPM3HQ #8324

Merged
merged 4 commits into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@ganesh-ramachandran
Contributor

ganesh-ramachandran commented Oct 4, 2018

Description

Add mbed support for TOSHIBA's TMPM3HQ board

Tested with all toolchains and test results are attached.
M3HQ_GreenteaAutomated_TestResults.txt

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you create an issue report please

@0xc0170 0xc0170 requested a review from ashok-rao Oct 4, 2018

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 4, 2018

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you create an issue report please

Created issue report #8326

@ashok-rao

Thanks @ganesh-ramachandran ..left some comments.

@@ -0,0 +1,284 @@
/* mbed Microcontroller Library

This comment has been minimized.

@ashok-rao

ashok-rao Oct 4, 2018

Contributor

@ganesh-ramachandran : I see the SPI API implemented but don't see the pin definitions in PinNames.h .. any reason??

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Oct 5, 2018

Contributor

Hi @ashok-rao, added the SPI pin definitions in PinNames.h

/* Linker script to configure memory regions. */
MEMORY
{
FLASH (rx) : ORIGIN = 0x00000000, LENGTH = 512K

This comment has been minimized.

@ashok-rao

ashok-rao Oct 4, 2018

Contributor

I didn't find the "MBED_APP_START" macro.. any reason not to have this defined in all the 3 toolchain's linker descriptions?

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Oct 5, 2018

Contributor

Hi @ashok-rao, added "MBED_APP_START" macro in all 3 toolchain's linker descriptions.

SW2 = PV1,
SW3 = PV2,
SW4 = PV3,

This comment has been minimized.

@ashok-rao

ashok-rao Oct 4, 2018

Contributor

@ganesh-ramachandran : No SPI pins brought out on the board?

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Oct 5, 2018

Contributor

Hi @ashok-rao, added the SPI pin definitions in PinNames.h

SW1 = PV0,
SW2 = PV1,
SW3 = PV2,
SW4 = PV3,

This comment has been minimized.

@ashok-rao

ashok-rao Oct 4, 2018

Contributor

Can you please create an alias for "USER_BUTTON" just to maintain consistency with other mbed targets? Thanks.

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Oct 5, 2018

Contributor

Hi @ashok-rao, added the alias for "USER_BUTTON".

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 4, 2018

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you try updating your htrun https://github.com/ARMmbed/htrun#installation-from-python-sources I'd recommend installing latest htrun from sources..

@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 4, 2018

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 5, 2018

In single test, we are getting error TypeError: coercing to Unicode: need string or buffer, list found from version 5.10 and master. No error in version 5.9.

Can you try updating your htrun https://github.com/ARMmbed/htrun#installation-from-python-sources I'd recommend installing latest htrun from sources..

Installed the latest htrun from given link.
But getting same error by executing single test command.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 5, 2018

Strange.. That unicode error should not be present in the latest build of htrun.. can you try updating your greentea as well? It's most probably a python issue somewhere rather than the implementation..

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 9, 2018

Strange.. That unicode error should not be present in the latest build of htrun.. can you try updating your greentea as well? It's most probably a python issue somewhere rather than the implementation..

Hi @ashok-rao, we have updated the greentea as well as all the tools but getting same error.

Below is the versions of different tools:

- Windows		: 8.1 pro – 64 bit
- Python		: 2.7.14
- Mbed-cli		: 1.8.2
- Greentea		: 1.4.0
- Mbedhtrun		: 1.4.1
- Pip			: 18.1
- Git Bash(git)		: 2.15.1.windows.2
- Mercurial(hg)		: 4.5

And traceback report we have attached in issue #8326 (comment)

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 10, 2018

@theotherjimmy .. any thoughts why htrun might be failing with unicode errors?

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 15, 2018

Hi @ashok-rao since htrun/single test having issues with latest mbed, could we post the results of single test with mbed v5.9.6 to progress this PR.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 15, 2018

I'm afraid this PR would need everything with the version of Mbed OS it was ported against @ganesh-ramachandran .. sorry about that!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 24, 2018

@ganesh-ramachandran Getting back to this . Is there any update? Tests are passing as I understood. Only singletest.py problem was there (@cmonr reminder to review the referenced issue above).

This needs a rebase.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 24, 2018

@0xc0170 Yup! (Finally have bandwidth to)

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 25, 2018

@ganesh-ramachandran Getting back to this . Is there any update? Tests are passing as I understood. Only singletest.py problem was there (@cmonr reminder to review the referenced issue above).

This needs a rebase.

@0xc0170 Only singletest has problem. Other than that no updates. Rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

As this new target is only for Mbed OS 5, the singletest issue should not gate this.

I'll review shortly. @ashok-rao is OoO this week, expecting a review early next week (or @MarceloSalazar can review instead?)

@@ -0,0 +1,13 @@
/* mbed Microcontroller Library - CMSIS for TMPM3HQ

This comment has been minimized.

@0xc0170

0xc0170 Oct 25, 2018

Member

Should be the same license header as in other files targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/gpio_api.c .

Also cmsis_nvic.h

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Oct 26, 2018

Contributor

Updated the license header

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

I would like to test exporters (new device name, IAR) to check if we need an update in our CI

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

I'll request new cmsis pack for this device.

What IAR version is required ? If it is not supported in IAR 7.8, we should remove this from iar definitions. Until we get IAR 8.x support

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

Created internal ticket IOTTESTINF-4538 for cmsis-pack update

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 25, 2018

@ganesh-ramachandran Would you happen to know exactly which CMSIS pack is needed for this new target?

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Oct 26, 2018

What IAR version is required ? If it is not supported in IAR 7.8, we should remove this from iar definitions. Until we get IAR 8.x support

Hi @0xc0170 IAR version 8.22 is required for TMPM3HQ. Hence removed from iar definitions.

@ganesh-ramachandran Would you happen to know exactly which CMSIS pack is needed for this new target?

https://www.keil.com/dd2/toshiba/tmpm3hqfdfg/

"is_disk_virtual": true,
"extra_labels": ["TOSHIBA"],
"macros": ["__TMPM3HQ__"],
"supported_toolchains": ["GCC_ARM", "ARM", "IAR"],

This comment has been minimized.

@ashok-rao

ashok-rao Nov 5, 2018

Contributor

@ganesh-ramachandran : If we are removing IAR support until mbed OS supports IAR 8.x, then "IAR" from supported_toolchains should be removed too. Thanks.

This comment has been minimized.

@0xc0170

0xc0170 Nov 5, 2018

Member

@ganesh-ramachandran : If we are removing IAR support until mbed OS supports IAR 8.x, then "IAR" from supported_toolchains should be removed too. Thanks.

It should compile it (needs core), so can stay as it is, just definition removal

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Nov 5, 2018

@0xc0170 / @cmonr : This PR is looking good now - except for CMSIS pack update in our CI and IAR support removed in the PR (this comment..until 8.x support is available), it should be good to go through CI..also note the 1 failing GT test (#8326 )

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 5, 2018

IOTTESTINF-4538

The ticket is in progress, we will report back once the pack is in place. Sorry for the delay

Ganesh Ramachandran added some commits Oct 5, 2018

Ganesh Ramachandran Ganesh Ramachandran
Removed IAR export definition for M3HQ
Since not supported in IAR 7.8, removed from iar definitions.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Nov 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 8, 2018

CI machine was updated.

/morph build

@0xc0170

0xc0170 approved these changes Nov 8, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 8, 2018

Known issue with CI, we are investigating

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 9, 2018

Build : SUCCESS

Build number : 3587
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8324/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 9, 2018

@0xc0170 0xc0170 merged commit 662b744 into ARMmbed:master Nov 9, 2018

18 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9739 cycles (-188 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Nov 9, 2018

@ganesh-ramachandran ganesh-ramachandran deleted the ganesh-ramachandran:m3hq_new_target branch Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment