mbed dm: Check for missing payload and give a better error message #8334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
The error message when you invoke `mbed dm update prepare` without a payload
is particularly obtuse, and provides a user with no indication that the
payload is missing. This change makes that error message not stink.
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
0xc0170
approved these changes
Oct 5, 2018
|
/morph build |
Build : SUCCESSBuild number : 3331 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2963 |
Test : SUCCESSBuild number : 3139 |
cmonr
approved these changes
Oct 12, 2018
cmonr
added
ready for merge
release-version: 5.10.2
and removed
needs: CI
release-version: 5.11.0-rc1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message when you invoke
mbed dm update preparewithout a payloadis particularly obtuse, and provides a user with no indication that the
payload is missing. This change makes that error message not stink.
@maclobdell Thanks for pointing this out offline.
Pull request type