New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed dm: Check for missing payload and give a better error message #8334

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Oct 5, 2018

Description

The error message when you invoke mbed dm update prepare without a payload
is particularly obtuse, and provides a user with no indication that the
payload is missing. This change makes that error message not stink.

@maclobdell Thanks for pointing this out offline.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
mbed dm: Check for missing payload and give a better error message
### Description

The error message when you invoke `mbed dm update prepare` without a payload
is particularly obtuse, and provides a user with no indication that the
payload is missing. This change makes that error message not stink.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
@0xc0170

0xc0170 approved these changes Oct 5, 2018

@cmonr

cmonr approved these changes Oct 8, 2018

👍

@cmonr cmonr added the needs: CI label Oct 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 12, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3331
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8334/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Oct 12, 2018

@cmonr cmonr merged commit 7ea50f1 into ARMmbed:master Oct 12, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 629 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9101 cycles (-817 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment