New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Reduced SPIF Block Device for Boot Loader #8349

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
6 participants
@offirko
Contributor

offirko commented Oct 9, 2018

Description

Adding the original Reduced SPIF Block Device into mbed-os to be used only by the Boot Loader.
(The existing SPIF Block Device supports SFDP standard but is too large for the Boot Loader.)

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@offirko

This comment has been minimized.

Contributor

offirko commented Oct 9, 2018

@bulislaw , @donatieng , @ARMmbed/mbed-os-maintainers , @dannybenor , @davidsaada .
I'd appreciate your review of a Reduced SPIF Block Device for Boot Loader use.

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-maintainers Oct 9, 2018

@cmonr cmonr requested review from donatieng, davidsaada and bulislaw Oct 11, 2018

@@ -0,0 +1,109 @@
{
"name": "rspif-driver"

This comment has been minimized.

@0xc0170

0xc0170 Oct 16, 2018

Member

Can this be formatted better? It's hard to read as it is

#define MBED_RSPIF_BLOCK_DEVICE_H
/*
#include <mbed.h>

This comment has been minimized.

@0xc0170

0xc0170 Oct 16, 2018

Member

why is this commented out? It would be better to remove it

Comments addressed. Please re-review.

@offirko

This comment has been minimized.

Contributor

offirko commented Oct 17, 2018

@cmonr - unittest failed on non-related issue (lora), could you please trigger tests again?

@cmonr cmonr added needs: CI and removed needs: review labels Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3390
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8349/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 18, 2018

@cmonr cmonr merged commit 515db95 into ARMmbed:master Oct 18, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(-108 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 667 files (+1 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9193 cycles (+53 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment