New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding build timestamp from env #8359

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@kaidokert
Contributor

kaidokert commented Oct 10, 2018

Description

Small tweak to build scripts to allow much faster cached builds with ccache and other cache drivers. Local cache such as ccache does not work if -DMBED_BUILD_TIMESTAMP=xy is passed with different value every instantiation. Allowing override through env to a fixed value enables speeding up the local builds substantially.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kaidokert kaidokert force-pushed the kaidokert:master branch from 1b4199d to 77f9fb9 Oct 10, 2018

@cmonr cmonr requested review from theotherjimmy, cmonr and bridadan Oct 10, 2018

@cmonr cmonr added the needs: review label Oct 10, 2018

@bridadan

I really like this solution!

@cmonr

cmonr approved these changes Oct 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3376
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8359/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph mbed2-build

@cmonr cmonr merged commit a5855e4 into ARMmbed:master Oct 17, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 653 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9186 cycles (-1138 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment