New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas : Minor change of SPI driver #8379

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Oct 11, 2018

Description

I change SPI driver a bit for matching policy with other Renesas drivers.

If the specified frequency exceeds the upper limit and lower limit at SPI driver, an error is output, but this does not match policy with other renesas drivers. Thus I change the processing as follows.

  • If "hz" is maximum over, it is rounded by the maximum value.
  • If "hz" is minimum under, it is rounded by the minimum value.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Improve frequency setting proc of Renesas SPI driver
If the specified frequency exceeds the upper limit and lower limit at SPI driver, an error is output, but this does not match policy with other renesas drivers. Thus I revises the processing as follows.
- If "hz" is maximum over, it is rounded by the maximum value.
- If "hz" is minimum under, it is rounded by the minimum value.

@cmonr cmonr requested a review from ARMmbed/team-renesas Oct 11, 2018

@cmonr

cmonr approved these changes Oct 11, 2018

@cmonr cmonr removed the request for review from ARMmbed/team-renesas Oct 11, 2018

@cmonr cmonr added the needs: CI label Oct 11, 2018

@cmonr cmonr merged commit 470f9bc into ARMmbed:master Oct 15, 2018

11 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 655 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9109 cycles (-19 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@TomoYamanaka TomoYamanaka deleted the TomoYamanaka:improve_spi_drv branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment