New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mts dragonfly l471 qg #8382

Closed
wants to merge 25 commits into
base: mbed-os-5.10
from

Conversation

Projects
None yet
9 participants
@AnttiKauppila
Contributor

AnttiKauppila commented Oct 11, 2018

Description

Fixed #7304 to fit to mbed-os-5.10 branch
Multitech will need to have it in 5.10.2 patch release latest.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 11, 2018

The DNM label is for us. This will be cherry picked once it's passed CI and 5.10.2 is being generated.

@AnttiKauppila AnttiKauppila force-pushed the AnttiKauppila:MTS_DRAGONFLY_L471QG branch from fec5cf6 to 33a315d Oct 11, 2018

@cmonr cmonr requested a review from ARMmbed/team-multitech Oct 11, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 11, 2018

@cedrickkukela-cd Wasn't able to add you as a reviewer, but please take a look as well.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2018

the only change here compare to master is 33a315d (this resolves the conflict) ?

@felser

felser approved these changes Oct 11, 2018

Looks good to me.

@maclobdell

maclobdell approved these changes Oct 12, 2018 edited

I approve just to make sure I don't block this further. I will run the tests asap, but my test setup (sim and/or network coverage) has been known not to work well. I have sent additional units to Oulu to test. Please go ahead and merge. We will confirm all test results as soon as possible before providing official Mbed Enabled approval.

@AnttiKauppila AnttiKauppila force-pushed the AnttiKauppila:MTS_DRAGONFLY_L471QG branch from 33a315d to fd7bcc4 Oct 12, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Oct 12, 2018

@felser you are right. I modified the code to work correctly

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 12, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Oct 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3338
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8382/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 14, 2018

looks like iar license related issue - rerunning

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 14, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 14, 2018

@cmonr this passed CI, is the "do not merge" flag still relevant?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 15, 2018

@NirSonnenschein Yes, because this will be cherry picked into the release branch as a part of generating the next patch release instead of being directly merged.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 22, 2018

Closing since this has been successfully cherry-picked into 5.10.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment