New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedgt-network-wifi WIFI_CONNECT - check for empty passwd #8469

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
4 participants
@VeijoPesonen
Contributor

VeijoPesonen commented Oct 18, 2018

Description

Providing empty password for unsecure Wifi connection should be fine from test case point of view

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change
@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Oct 18, 2018

@ARMmbed/mbed-os-ipcore please review

@cmonr cmonr added the needs: CI label Oct 18, 2018

@cmonr

cmonr approved these changes Oct 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

+1 for testing difference between an empty string and NULL

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2018

Build : SUCCESS

Build number : 3400
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8469/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 03f4623 into ARMmbed:master Oct 18, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 671 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9165 cycles (-1154 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment